redirect-module
redirect-module copied to clipboard
fix: don't forward error from decodeURI to next middleware
Instead of forwarding error from decodeURI further to the
error middleware and subsequently triggering 500 response, just ignore it.
Ignoring the error will likely crash in Nuxt later anyway but that is better as:
- This package won't get the blame when error shows up locally or in production
- Error triggered within Nuxt doesn't trigger 500 but 400 response which is better as this is input error rather than server error.
Codecov Report
Merging #76 (a0b7b6e) into master (a796553) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 37 37
Branches 8 8
=========================================
Hits 37 37
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/module.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a796553...a0b7b6e. Read the comment docs.
No one in here?