pwa-module icon indicating copy to clipboard operation
pwa-module copied to clipboard

feat(meta): preload manifest

Open pi0 opened this issue 4 years ago • 1 comments

(fixes #382) Currently, lighthouse suggests preloading manifest:

image

Following up twitter thread using as="fetch" suggested method by @addyosmani:

<link data-n-head="ssr" rel="preload" href="..." as="fetch">

This currently leads to this browser warning: ([email protected])

The resource http://localhost:4000/_nuxt/manifest_test.webmanifest?d860351d was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate as value and it is preloaded intentionally.

It seems there is currently a similar active discussion about related issue regarding rel="document (chromium/593267#c39)

pi0 avatar Oct 19 '20 19:10 pi0

Codecov Report

Merging #383 (44ad7af) into main (3ebfd1a) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   84.67%   84.71%   +0.03%     
==========================================
  Files          12       12              
  Lines         398      399       +1     
  Branches      121      121              
==========================================
+ Hits          337      338       +1     
  Misses         56       56              
  Partials        5        5              
Impacted Files Coverage Δ
lib/meta/module.js 78.57% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ebfd1a...44ad7af. Read the comment docs.

codecov[bot] avatar Oct 19 '20 20:10 codecov[bot]