google-optimize-module icon indicating copy to clipboard operation
google-optimize-module copied to clipboard

Published 20 hours ago • verified publisher icon nuxt-community

isEligible should fire on route change

Open uptownhr opened this issue 6 years ago • 3 comments

Maybe I'm not understanding the intent of isEligible but I feel this should be continuously checked as route is being changed. Resulting in a experiment being able to be inactive until a user reaches a certain route.

uptownhr avatar Sep 28 '18 19:09 uptownhr

PRs welcome for this enhancement :)

pi0 avatar Sep 28 '18 20:09 pi0

I would love to see this feature works with route change, for now isEligible looks usless.

kwolniak avatar Feb 03 '21 11:02 kwolniak

@kwolniak Someone started a PR for it a while ago: https://github.com/nuxt-community/google-optimize-module/pull/7

It would be great if you could continue the whole idea.

farzadso avatar Feb 04 '21 07:02 farzadso