axios-module
axios-module copied to clipboard
Add proxyCookies option
This PR adds a proxyCookies option which resolves #333.
An issue with this PR is that it includes the cookie package and other code both on the server and client, while it only has to run on the server. It would be better to only include it on the server, but I'm unsure how that can be done.
I also haven't added any tests, because I'm not sure how this can be properly tested.
Codecov Report
Merging #358 into dev will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## dev #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 31 31
Branches 13 13
=========================================
Hits 31 31
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/module.js | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0f20c51...891c34a. Read the comment docs.
@pi0 Still get problems with ssr cookie. Any idea about merge this pull request?
@pi0 can you clarify please, Nuxt 3 have same behavior, or this cookie-proxy is obsolete?