axios-module icon indicating copy to clipboard operation
axios-module copied to clipboard

Add proxyCookies option

Open SebastiaanYN opened this issue 5 years ago • 3 comments

This PR adds a proxyCookies option which resolves #333.

An issue with this PR is that it includes the cookie package and other code both on the server and client, while it only has to run on the server. It would be better to only include it on the server, but I'm unsure how that can be done.

I also haven't added any tests, because I'm not sure how this can be properly tested.

SebastiaanYN avatar May 03 '20 14:05 SebastiaanYN

Codecov Report

Merging #358 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           31        31           
  Branches        13        13           
=========================================
  Hits            31        31           
Impacted Files Coverage Δ
lib/module.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f20c51...891c34a. Read the comment docs.

codecov[bot] avatar May 03 '20 14:05 codecov[bot]

@pi0 Still get problems with ssr cookie. Any idea about merge this pull request?

k0mar12 avatar Nov 08 '20 16:11 k0mar12

@pi0 can you clarify please, Nuxt 3 have same behavior, or this cookie-proxy is obsolete?

arkhamvm avatar Nov 21 '22 03:11 arkhamvm