axios-module icon indicating copy to clipboard operation
axios-module copied to clipboard

Brotli support removed

Open Francois-Francois opened this issue 5 years ago • 4 comments

What problem does this feature solve?

In the past, Brotli was not supported on nodejs servers.

If I understand correctly, this is now supported since a few months : https://github.com/nodejs/node/pull/20458

This PR dropped support for Brotli : https://github.com/nuxt-community/axios-module/pull/180

Maybe it's time to revert this BR because Axios is supporting it too : https://github.com/axios/axios/pull/2071

What does the proposed changes look like?

Revert this PR https://github.com/nuxt-community/axios-module/pull/180

This feature request is available on Nuxt community (#c270)

Francois-Francois avatar Aug 19 '19 16:08 Francois-Francois

Reverting isn't enough as Brotli isn't supported in all version. One would have to do a check like in axios/axios#2071

Other than that, I absolutely agree.

TheAlexLichter avatar Aug 19 '19 17:08 TheAlexLichter

Thanks @rikless for report.

pi0 avatar Apr 21 '20 20:04 pi0

As the axios is not support brotli now, you should drop server side Brotli support at this time.

ITJesse avatar Apr 22 '20 15:04 ITJesse

I recommend revet this commit: https://github.com/nuxt-community/axios-module/commit/074f98cbdf409473357b2cd24cd6cb13fe75f149

ITJesse avatar Apr 22 '20 15:04 ITJesse