Nuwan Goonasekera

Results 136 comments of Nuwan Goonasekera

Not sure I follow - would the redis cache you proposed for toolsource documents be targeted for that purpose only? Even in that case, a key-value cache is simple enough...

Thanks for catching the issue with `max_pod_retries = min(max_pod_retries, self.runner_params["k8s_job_spec_back_off_limit"])`. That definitely looks odd. If `k8s_job_spec_back_off_limit` is set to zero (default), it looks like max_pod_retries will also become zero. Does...

Yes, it looks like the currently logic is not covering the full spectrum of possible k8s job states. As a result, it's just falling into the `else` clause and failing...

The enable_account_interface flag is alrrady presenr so i dont think we need #21356 for this.

@jdavcs I made a commit which adds the migration scripts + tests but I'm not sure I got the alembic migration process right - would be great if you could...

@jdavcs I changed the down_revision and rebased on dev, which seems to have solved the migration problem, but please let me know whether that's ok

Thanks for the feedback @jdavcs. There is a schema change here - the CustosAuthnzToken table has been dropped. I just didn't do it in the migration itself in-order to be...

Thanks @jdavcs. I've moved the migration logic to data_fixes as you suggested, dropped the CustosAuthnzToken table from the model and adjusted the upgrade/downgrade script to drop/restore the table and migrate/restore...

> @nuwang is it possible with this PR to have multiple keycloak providers? No, I tried to avoid making additional changes, just so the PR doesn't balloon too much, but...

I've tested upgrades and downgrades as follows: 1. Use latest dev branch 2. Setup a PSA idp for Google auth 3. Setup a Custos idp for Keycloak running locally 4....