ui_patterns icon indicating copy to clipboard operation
ui_patterns copied to clipboard

Issue#304: Detect all theme patterns.

Open kp77 opened this issue 4 years ago • 2 comments

This PR attempts to solve multiple issues originating from the \Drupal\ui_patterns_library\Plugin\Deriver\LibraryDeriver::getDirectories method collecting only the default theme and the base theme directories.

Besides the issues described in #304 and #308, I also had errors during site install with existing config, when using patterns in layout builder, because during install the default theme is stark.

This PR is a follow up to PRs #305 and #310 and uses the method suggested here: https://github.com/nuvoleweb/ui_patterns/issues/304#issuecomment-687164731

kp77 avatar Dec 09 '20 12:12 kp77

+1 on this! Thanks @kp77 this is IMO the proper fix.

vever001 avatar Dec 09 '20 16:12 vever001

This just solved our problem with patterns not showing up in a multi-domain setup, where we use a different theme for each domain:

Our steps to reproduce

(We only use patterns on domain 2)

  • drush cr
  • Visit domain 1
  • domain 2 patterns are broken
  • drush cr
  • Visit domain 2
  • domain 2 patterns are NOT broken

Oddly, once we deinstall ui_patterns_library, the patterns will never show up.

geek-andi avatar Mar 08 '22 19:03 geek-andi

Moved to Drupal.org https://www.drupal.org/project/ui_patterns/issues/3311471

mika2na avatar Sep 23 '22 13:09 mika2na