ui_patterns icon indicating copy to clipboard operation
ui_patterns copied to clipboard

Contextual links are lost when a pattern is rendered

Open tanc opened this issue 8 years ago • 9 comments

Using a pattern for the output of a node, the node's contextual links are not passed through to the template for rendering. It would be useful to have these available for printing in the twig file so as not to lose functionality and UX.

tanc avatar Jun 27 '17 14:06 tanc

Hello @tanc ! So you use a pattern to render, say, a node teaser view mode and then contextual links are not working anymore right?

ademarco avatar Aug 25 '17 05:08 ademarco

@ademarco exactly!

yannickoo avatar Aug 25 '17 09:08 yannickoo

Hey guys, could you check if the current branch works for you? It assumes that the containing pattern element has position: relative; but that's on the theme level, hence outside the scope of the module.

ademarco avatar Aug 26 '17 09:08 ademarco

could you check if the current branch works for you?

@ademarco I cannot see any new commits or am I missing something?

yannickoo avatar Aug 28 '17 09:08 yannickoo

@yannickoo check the 104-contextual-links branch, it hasn't been merged into 8.x-1.x yet.

@ademarco I'll try and test this week, thanks for the commit!

tanc avatar Aug 28 '17 09:08 tanc

Has anyone confirmed that the contextual menus work correctly now?

damienmckenna avatar Jan 18 '18 15:01 damienmckenna

Apologies, I never got to test properly as a project using UI Patterns finished and another one hasn't started yet. I should be able to test on a new project soon

tanc avatar Jan 18 '18 16:01 tanc

Finally got round to testing this and its looking good. With this patch the contextual links are showing for node based patterns. I wasn't getting contextual links for views based patterns.

tanc avatar Apr 30 '18 19:04 tanc

The fix from 104-contextual-links doesn't appear to fix the issue of my layout pattern showing its contextual links.

greenSkin avatar Feb 10 '21 20:02 greenSkin