nutz icon indicating copy to clipboard operation
nutz copied to clipboard

fix issue #1361

Open wendal opened this issue 6 years ago • 6 comments

wendal avatar Dec 01 '17 02:12 wendal

Codecov Report

Merging #1362 into master will decrease coverage by 0.04%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   47.42%   47.38%   -0.05%     
==========================================
  Files         810      810              
  Lines       34697    34703       +6     
  Branches     7511     7512       +1     
==========================================
- Hits        16456    16444      -12     
- Misses      16071    16088      +17     
- Partials     2170     2171       +1
Impacted Files Coverage Δ
src/org/nutz/ioc/impl/PropertiesProxy.java 35.21% <100%> (ø) :arrow_up:
src/org/nutz/lang/util/MultiLineProperties.java 56% <87.5%> (+0.68%) :arrow_up:
src/org/nutz/mvc/view/HttpServerResponse.java 18.47% <0%> (-9.79%) :arrow_down:
src/org/nutz/mvc/impl/NutActionChain.java 60.6% <0%> (-6.07%) :arrow_down:
src/org/nutz/mvc/view/HttpStatusView.java 28.94% <0%> (-5.27%) :arrow_down:
src/org/nutz/lang/Streams.java 48.96% <0%> (-1.04%) :arrow_down:
src/org/nutz/mvc/WhaleFilter.java 27.35% <0%> (-0.95%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcf5199...3102f13. Read the comment docs.

codecov-io avatar Dec 01 '17 03:12 codecov-io

加一个行为开关会不会更好一些? 默认是key,value左右都trim的 开关切换后,和jdk自带的properties行为一致

happyday517 avatar Jan 05 '18 02:01 happyday517

不过话说,jdk自带的properties行为也像是一种疏忽 我还是倾向于全部trim了 ^_^

happyday517 avatar Jan 05 '18 03:01 happyday517

-_- 还没决定,不知道如何是好...

wendal avatar Jan 05 '18 05:01 wendal

PropertiesProxy 加一个构造方法,填加一个开关参数,默认为关,当打开时启动 trim。各取所需,呵呵。

qinerg avatar Nov 11 '19 11:11 qinerg

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 13 '22 08:05 CLAassistant