notes
notes copied to clipboard
nuttyartist
App is crashing on Windows 7
A friend of mine tried to install the app, but get an error message that says that "MSVCP120.dll is missing".
@theshadowx Maybe it's because our config on AppVeyour doesn't include that? Should we include that?
I think the installer you made doesn't include it, as windeployqt doesn't add it. In the appveyor, I have manually added it to the folder from which the bunder will be generated : https://github.com/nuttyartist/notes/blob/dev/appveyor.yml#L63-L67
- cd C:\ci\notes\bin
- windeployqt .
- if %compiler%==msvc2015 copy "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\redist\\x86\\Microsoft.VC140.CRT\\msvcp140.dll" .
- if %compiler%==msvc2015 copy "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\redist\\x86\\Microsoft.VC140.CRT\\vcruntime140.dll" .
- if %compiler%==msvc2015_64 copy "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\redist\\x64\\Microsoft.VC140.CRT\\msvcp140.dll" .
- if %compiler%==msvc2015_64 copy "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\redist\\x64\\Microsoft.VC140.CRT\\vcruntime140.dll" .
- iscc C:\ci\notes\packaging\windows\Notes_Inno_Script.iss
- cd C:\ci\notes\installer
But it states "MSVCP120.dll" on my friend's machine, not msvcp140.dll. And indeed, my fault, I probably forgot to add these necessary libraries.
yes because you used msvc 120 (2013) to compile the source code and the version used in appveyor is 140 (2015).
the dll follows the version of the compiler which you used
msvc 120 (2013) needs msvcp120.dll / vcruntime120.dll msvc 140 (2015) needs msvcp140.dll / vcruntime140.dll
just to check : go to your appveyor Notes page and select
You'll find in Artifacts tab:
Donwload the one with long name.
And try it, in theory it won't tell you that dll is missing.
Yeah, he said the link solved its problem. @theshadowx Are we still unable to create one Windows installer using AppVeyour (for both 32bit and 64bit)?
Ok, so I will create a new installer and upload it to the site. The real bummer here is that a new installer will probably lose all the popularity gained with the previous one, and thus, will be affected by Windows warnings. My fault on this.
@theshadowx Is it good to use the AppVeyor's artifacts for the installer, rather for me to compile them every time on both 32bit and 64bit, and only packaging them together on 32bit VM?
I think it's better to use the package generated from appVeyor, as it's clean environment.
