NuttX PR comments

Results 61 comments of


                                            NuttX PR

syslog: Don't allow blocking when in signal handler

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is missing some key information: * **What functional part of the code is being changed?** Be specific, e.g., "the syslog implementation" or...

sched/task_exit.c: Refresh current CPU instead of relying on stale value

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The provided PR description does not meet all of the NuttX requirements. Here's a breakdown: **Strengths:** * **Clear Summary:** The summary explains the problem (incorrect...

generate errno definitions from CSV

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary....

pm_idle.c add support for smp case.

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests) __Squash The Commits:__ This PR contains 4 Commits. Please Squash the Multiple Commits into a Single Commit. The PR summary and impact sections seem to...

examples: New app to build Rust with Cargo

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## PR Requirements Review **Meeting Requirements?** Partially **Summary:** * **Why?** Provides a more common and ecosystem-friendly way to build Rust applications for NuttX. * **What?**...

Add pipeline support for nsh commandline

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR partially meets the NuttX requirements. **Strengths:** * **Summary** provides a clear explanation of the changes and their purpose. * **Testing** section includes specific...

arhc/arm64: vector table may be far away form arm64_fatal_handle

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## NuttX PR Requirements Review The provided PR description is **missing crucial information** to meet the NuttX requirements. **Here's a breakdown:** **Summary:** * **Missing:** A...

userspace: Exclude nuttx/arch.h

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR seems to meet most of the NuttX requirements. However, there are some areas that could be improved: **Summary:** * **Good:** Provides a clear...

arch/x86_64: Reimplement the NuttX32 multiboot1 wrapper.

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR description doesn't fully meet the NuttX requirements. Here's a breakdown: **Strengths:** * **Summary:** Clearly states the problem, solution, and affected code area. *...

drivers/leds: Add support for KTD2052

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. Here's why and how to fix it: * **Summary:** While it states *what* was...