pixiedust icon indicating copy to clipboard operation
pixiedust copied to clipboard

CRAN Check Failure for Upcoming broom Release

Open simonpcouch opened this issue 4 years ago • 0 comments

Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below.

  • checking tests ...
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      > 
      > test_check("pixiedust")
      [31m──[39m [31m1. Error: dust runs when passed a data frame with tidy_df = TRUE (@test-dust.[39m
      No tidy method for objects of class data.frame
      [1mBacktrace:[22m
      [90m  1. [39mtestthat::expect_warning(dust(mtcars, tidy_df = TRUE))
      [90m  7. [39mpixiedust:::dust.default(mtcars, tidy_df = TRUE)
      [90m 10. [39mbroom:::tidy.default(object, ...)
    
      ══ testthat results  ═══════════════════════════════════════════════════════════
      [ OK: 512 | SKIPPED: 120 | WARNINGS: 0 | FAILED: 1 ]
      1. Error: dust runs when passed a data frame with tidy_df = TRUE (@test-dust.R#52) 
    
      Error: testthat unit tests failed
      Execution halted
    

broom will now natively error when passed objects which don't have tidier methods implemented.

We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!🙂

simonpcouch avatar May 27 '20 16:05 simonpcouch