react-router-breadcrumbs icon indicating copy to clipboard operation
react-router-breadcrumbs copied to clipboard

react-router 4.0.0 support

Open GreenAsJade opened this issue 7 years ago • 6 comments

Just noting that react-router is on 4.0.0 now, but react-router-breadcrumbs specifies 3.x.x. only.

GreenAsJade avatar Mar 13 '17 08:03 GreenAsJade

Thanks for adding this issue. 👍

[email protected] is a complete rewrite of the library, so I will have to take a look at it. At first glance it seems like a complete rewrite of this library is also necessary to be compliant with the new version.

nutgaard avatar Mar 13 '17 13:03 nutgaard

Dang, eh?!

GreenAsJade avatar Mar 13 '17 22:03 GreenAsJade

Have you looked into this rewrite? I'm beginning to think breadcrumbs will be a complex component to build with this v4 update since routes are not explicit.

shawnmclean avatar Apr 08 '17 05:04 shawnmclean

Hi @shawnmclean Things are a bit busy at work right now, so I haven't gotten around to it yet.

If you want though a PR is allways welcomed. :)

nutgaard avatar Apr 08 '17 07:04 nutgaard

Related discussion of v4 upgrade options over at svenanders/react-breadcrumbs#99 if anyone is interested. As you've all noted this will definitely be a tough problem to solve with the new rewrite.

skipjack avatar Jun 07 '17 14:06 skipjack

This is like abandoned for quite some time! At least a deprecation notice will be useful in README.

https://github.com/nutgaard/react-router-breadcrumbs/pull/303

hiradyazdan avatar May 08 '20 12:05 hiradyazdan