nusmods icon indicating copy to clipboard operation
nusmods copied to clipboard

Replace messenger with telegram

Open mug1wara26 opened this issue 1 year ago • 4 comments

Context

Messenger group is no longer used, adds a telegram button to the contribute page and replaces all other mentions of messenger with telegram. Issue: https://github.com/nusmodifications/nusmods/issues/3794

Implementation

Replace the messenger button with a telegram button. The background color uses the telegram background color and the icon uses the Send icon from react-feather

image

Other Information

mug1wara26 avatar Aug 21 '24 07:08 mug1wara26

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:01am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:01am

vercel[bot] avatar Aug 21 '24 07:08 vercel[bot]

@mug1wara26 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 21 '24 07:08 vercel[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.60%. Comparing base (988c6fd) to head (c3fc859). Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
website/src/views/settings/BetaToggle.tsx 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
+ Coverage   54.52%   54.60%   +0.08%     
==========================================
  Files         274      274              
  Lines        6076     6076              
  Branches     1455     1454       -1     
==========================================
+ Hits         3313     3318       +5     
+ Misses       2763     2758       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 21 '24 08:08 codecov[bot]

Hi thanks for this. However, I recently merged another commit that also adds Telegram buttons in some places. It would still be good to remove the FB messenger buttons though, so could you rebase your commit on top of the master branch?

zwliew avatar Aug 27 '24 07:08 zwliew

Thank you so much for this!

zwliew avatar Nov 18 '24 07:11 zwliew