Adjust timetable corner styles (#3340)

[miqh]

Context

Hello there.

This changeset is intended to resolve #3340 in which a minor visual issue was noted about the corners of the timetable.

Implementation

It was simply a matter of adding styles to the elements which weren't having their corners rounded.

I also found that the element which served to highlight the current day also needed some adjustment. This particular problem only manifests if the current day is the first or last day, corresponding to the top-most and bottom-most rows in the timetable respectively.

Other Information

None.

[vercel[bot]]

@miqh is attempting to deploy a commit to the NUSMods Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/2ch5Z1rNKiciyJrZtUQJWUh7hzNB
✅ Preview: https://nusmods-export-git-fork-miqh-fix-timeta-8cbacf-nusmodifications.vercel.app

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/6LHQiDEMQ2BUq5jXrbu8ELB817Zw
✅ Preview: https://nusmods-website-git-fork-miqh-fix-timet-96be2f-nusmodifications.vercel.app

[codecov[bot]]

Codecov Report

Patch coverage has no change and project coverage change: -0.27% :warning:

Comparison is base (a4f1a75) 53.11% compared to head (6b51e14) 52.84%.

:exclamation: Current head 6b51e14 differs from pull request most recent head 68f11fd. Consider uploading reports for the commit 68f11fd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3358      +/-   ##
==========================================
- Coverage   53.11%   52.84%   -0.27%     
==========================================
  Files         271      270       -1     
  Lines        5855     5724     -131     
  Branches     1397     1323      -74     
==========================================
- Hits         3110     3025      -85     
+ Misses       2745     2699      -46     

see 64 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[miqh]

Hello @chrisgzf.

I noticed that you pulled in changes from nusmodifications:master.

Just wondering whether there was anything extra that needs to be addressed so that the linked issue can be closed off.

[chrisgzf]

Hi @miqh, thanks for your contribution! Sorry about that, I was reviewing and testing your PR and I got sidetracked.

I just tested your changes on the deploy preview and using the original error case in #3340, which is adding LAJ2203 to the timetable, it seems like the issue still exists.

(see top right corner)

Did we miss something out in this PR?

[miqh]

@chrisgzf, no worries!

Ah, perhaps I've misunderstood the desired outcome.

I thought the linked issue was only drawing attention to the fact the border itself gets clipped by a corner wedge of an element being bordered underneath. My changes were intended to resolve this.

EDIT:

If instead the expected result is to eliminate the corner gap seen between a timetable cell and the border of the entire timetable, then I can see two solutions that could be taken:

• Preserve the existing timetable border radius and adjust the rounded variants of timetable cells
• Preserve the border radius of timetable cells and adjust the timetable border

I'd personally lean toward the first option because then the timetable component border radius is consistent with other UI elements like buttons and text inputs.

Thoughts?

[li-kai]

I would go with the second option here since the rounded corners indicate if the lessons are clickable. Reducing the radius would make it harder to differentiate. @ZhangYiJiang @chrisgzf second thoughts?

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nusmods-export	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2023 1:36am