nusmods icon indicating copy to clipboard operation
nusmods copied to clipboard

Navbar: shift center block left

Open bnjmnt4n opened this issue 4 years ago β€’ 4 comments

Context

The navbar links being at the centre made it look very uneven, especially with the search bar expanding to take up space on the right. This commit shifts the navbar links to the left, and aligns the padding of the navbar with the Today, Venues and Timetable components on the medium viewport widths.

Other Information

Here are screenshots of the timetable view at 2 different viewport breakpoints.

Large viewport

image

Medium viewport

image

bnjmnt4n avatar Feb 15 '21 10:02 bnjmnt4n

@bnjmnt4n is attempting to deploy a commit to the NUSMods Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 15 '21 10:02 vercel[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-export – ./export

πŸ” Inspect: https://vercel.com/nusmodifications/nusmods-export/aka5sh1k3
βœ… Preview: https://nusmods-export-git-fork-bnjmnt4n-eliang-new-nav-changes.nusmodifications.vercel.app

vercel[bot] avatar Feb 15 '21 10:02 vercel[bot]

Codecov Report

Merging #3239 (2be0f7a) into eliang/new-nav (27ec54c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           eliang/new-nav    #3239   +/-   ##
===============================================
  Coverage           55.59%   55.59%           
===============================================
  Files                 256      256           
  Lines                5324     5324           
  Branches             1226     1226           
===============================================
  Hits                 2960     2960           
  Misses               2364     2364           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 27ec54c...2be0f7a. Read the comment docs.

codecov[bot] avatar Feb 15 '21 10:02 codecov[bot]