nusmods
nusmods copied to clipboard
Filter exam clash
Context
#1184 Additional filter option in module finder to hide modules with exams that clash with those of already selected modules
Implementation
Added an additional filter checkbox in the module finder sidebar under the "Exams" section to allow users to filter out
modules whose exams clash with those they have already added to their timetable.
Implemented by connecting ModuleFinderSidebar
to redux store using the useSelector
hook and getting the active semester, modules already added to timetable and their semester data. From there, use the exam timings of the currently selected modules to generate FilterItem
to be used by the ChecklistFilter.
Other Information
This is my first time opening a PR to an open source project, please let me know if there's anything I'm doing wrongly!! π
Thanks for the PR! Could you run lint fix and resolve all of the lint issues so the build preview can run? https://app.circleci.com/pipelines/github/nusmodifications/nusmods/9966/workflows/e2e52d85-606b-4112-86ea-16477f18dd6a/jobs/68864
Codecov Report
Patch coverage has no change and project coverage change: -0.11%
:warning:
Comparison is base (
a88fef4
) 53.09% compared to head (ec3d635
) 52.99%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
- Coverage 53.09% 52.99% -0.11%
==========================================
Files 271 271
Lines 5855 5867 +12
Branches 1397 1398 +1
==========================================
Hits 3109 3109
- Misses 2746 2758 +12
Files Changed | Coverage Ξ | |
---|---|---|
website/src/views/modules/ModuleFinderSidebar.tsx | 0.00% <0.00%> (ΓΈ) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Deployment preview for fcad1c1a
ready at http://5fed1a2d1266047a2564bd0e--nusmods-deploy-preview.netlify.app
Hi @ZhangYiJiang , I've fixed the lint issues!
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
nusmods-website β ./website
π Inspect: https://vercel.com/nusmodifications/nusmods-website/ftsuqqkd9
β
Preview: https://nusmods-website-git-fork-tanleyang-filter-exam-clash.nusmodifications.vercel.app
nusmods-export β ./export
π Inspect: https://vercel.com/nusmodifications/nusmods-export/hw9xlpjku
β
Preview: https://nusmods-export-git-fork-tanleyang-filter-exam-clash.nusmodifications.vercel.app
The latest updates on your projects. Learn more about Vercel for Git βοΈ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Aug 8, 2023 4:31pm |
nusmods-website | β Ready (Inspect) | Visit Preview | π¬ Add feedback | Aug 8, 2023 4:31pm |
@zwliew is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.