nusmods icon indicating copy to clipboard operation
nusmods copied to clipboard

Filter exam clash

Open TanLeYang opened this issue 3 years ago β€’ 5 comments

Context

#1184 Additional filter option in module finder to hide modules with exams that clash with those of already selected modules

Implementation

Added an additional filter checkbox in the module finder sidebar under the "Exams" section to allow users to filter out modules whose exams clash with those they have already added to their timetable. Screenshot (20)

Implemented by connecting ModuleFinderSidebar to redux store using the useSelector hook and getting the active semester, modules already added to timetable and their semester data. From there, use the exam timings of the currently selected modules to generate FilterItem to be used by the ChecklistFilter.

Other Information

This is my first time opening a PR to an open source project, please let me know if there's anything I'm doing wrongly!! πŸ™

TanLeYang avatar Aug 30 '20 08:08 TanLeYang

Thanks for the PR! Could you run lint fix and resolve all of the lint issues so the build preview can run? https://app.circleci.com/pipelines/github/nusmodifications/nusmods/9966/workflows/e2e52d85-606b-4112-86ea-16477f18dd6a/jobs/68864

ZhangYiJiang avatar Sep 04 '20 19:09 ZhangYiJiang

Codecov Report

Patch coverage has no change and project coverage change: -0.11% :warning:

Comparison is base (a88fef4) 53.09% compared to head (ec3d635) 52.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2845      +/-   ##
==========================================
- Coverage   53.09%   52.99%   -0.11%     
==========================================
  Files         271      271              
  Lines        5855     5867      +12     
  Branches     1397     1398       +1     
==========================================
  Hits         3109     3109              
- Misses       2746     2758      +12     
Files Changed Coverage Ξ”
website/src/views/modules/ModuleFinderSidebar.tsx 0.00% <0.00%> (ΓΈ)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 05 '20 14:09 codecov[bot]

Hi @ZhangYiJiang , I've fixed the lint issues!

TanLeYang avatar Sep 05 '20 15:09 TanLeYang

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

πŸ” Inspect: https://vercel.com/nusmodifications/nusmods-website/ftsuqqkd9
βœ… Preview: https://nusmods-website-git-fork-tanleyang-filter-exam-clash.nusmodifications.vercel.app

nusmods-export – ./export

πŸ” Inspect: https://vercel.com/nusmodifications/nusmods-export/hw9xlpjku
βœ… Preview: https://nusmods-export-git-fork-tanleyang-filter-exam-clash.nusmodifications.vercel.app

vercel[bot] avatar Dec 30 '20 22:12 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nusmods-export βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 8, 2023 4:31pm
nusmods-website βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 8, 2023 4:31pm

vercel[bot] avatar Aug 08 '23 16:08 vercel[bot]

@zwliew is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

vercel[bot] avatar Aug 08 '23 16:08 vercel[bot]