nusmods icon indicating copy to clipboard operation
nusmods copied to clipboard

Add filter to hide modules with clashing exam time in module finder

Open ZhangYiJiang opened this issue 7 years ago • 6 comments

Currently the module finder has a filter for no exam date, but wouldn't it be great to also make it hide all exams that clash with the mods you've already picked?

Unfortunately implementing this is a bit tricky - our current filter system is designed using classes, and are initialized statically, while selected mods are stored in Redux, which means the filters need to be created dynamically instead. This has been done for search filters, so it's not impossible - look at the existing search filter code to see how this can be done, and ping me if you have any questions :)

ZhangYiJiang avatar Oct 01 '18 13:10 ZhangYiJiang

I'd like to work on this!

phoenix1796 avatar Oct 01 '18 18:10 phoenix1796

@phoenix1796 Please go ahead. Instructions for setting up can be found in the README: https://github.com/nusmodifications/nusmods/tree/master/www. You can talk to us on Telegram if you have any problems https://telegram.me/nusmods

ZhangYiJiang avatar Oct 02 '18 02:10 ZhangYiJiang

@phoenix1796 Hi there, any updates? If you have any difficulties feel free to ask for help here or in Telegram

ZhangYiJiang avatar Oct 18 '18 02:10 ZhangYiJiang

This issue doesn’t require a lot of experience with Redux, but I would suggest looking at something simpler if you’ve never written JavaScript before.

ZhangYiJiang avatar Nov 15 '18 15:11 ZhangYiJiang

Can I work on this?

andlimey avatar Sep 19 '19 06:09 andlimey

I would like to try working on this please!

TanLeYang avatar Aug 26 '20 17:08 TanLeYang

Resolved by #2845

zwliew avatar Aug 08 '23 16:08 zwliew