reedline icon indicating copy to clipboard operation
reedline copied to clipboard
verified publisher icon nushell

Different color struct

Open tisonkun opened this issue 1 year ago • 1 comments

https://github.com/nushell/reedline/blob/020142f6ee857353c289119a04d8fc71c474ce59/src/prompt/base.rs#L100-L106

Why do we use different color struct for similar prompt color settings?

Is it still possible to align them?

tisonkun avatar Aug 22 '24 03:08 tisonkun

That seems to be an oversight at some point. Not sure where the impact would be when changing to one or the other.

In general I am inclined to say we should simplify the prompt trait. In nushell most prompts do their own color ornamentation inside the prompt string so the whole notion of having prompt color(s) is a bit redundant.

sholderbach avatar Aug 22 '24 12:08 sholderbach