reedline icon indicating copy to clipboard operation
reedline copied to clipboard

incomplete key sequences should be completed first

Open crides opened this issue 1 year ago • 6 comments

Fixes an issue like #473 and #449, but for custom keybindings. Fixed by checking if the current key sequence is complete, and if not, complete it before checking for keybindings.

Added a test for this scenario

crides avatar Jan 02 '24 05:01 crides

Hey @crides, Will you be continuing to work on this PR or are you out of time/decided it's not useful?

fdncred avatar Feb 09 '24 12:02 fdncred

From local testing I think it's done

crides avatar Feb 09 '24 16:02 crides

the ci doesn't agree with you. 😆

fdncred avatar Feb 09 '24 17:02 fdncred

Huh, a bunch of things I didn't touch. I can fix later today

crides avatar Feb 09 '24 18:02 crides

aight there we go

crides avatar Feb 10 '24 05:02 crides

hmm this is not actually general enough (not accounting for insert mode bindings) but I don't think such a case can exist in insert mode right now (not even for custom bindings)? Examples in normal vim/zsh vi mode will be ^V and ^K for inserting characters/digraphs; or ^O if you wanna include that (temporary exit to normal mode; see :h i_^O)

crides avatar Feb 10 '24 05:02 crides