nushell icon indicating copy to clipboard operation
nushell copied to clipboard

Support parallel for `all?` command

Open Kangaxx-0 opened this issue 3 years ago • 3 comments

Description

Parallelism support for internal command all as requested from #6061

TODO - I will add parallelism support for other commands in different PRs

Tests

Make sure you've done the following:

  • [ ] Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder.
  • [ ] Try to think about corner cases and various ways how your changes could break. Cover them with tests.
  • [ ] If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works.

Make sure you've run and fixed any issues with these commands:

  • [x] cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • [x] cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • [x] cargo test --workspace --features=extra to check that all the tests pass

Kangaxx-0 avatar Aug 02 '22 16:08 Kangaxx-0

oh, nice! you come up with some interesting PRs!

fdncred avatar Aug 02 '22 19:08 fdncred

I'm doing some refactor of the engine which might make this a bit harder. We may want to hold off on adding more parallel commands until we get a good idea of how it will change how parallel code works in the engine.

sophiajt avatar Aug 04 '22 10:08 sophiajt

making this a draft considering jt's comments.

fdncred avatar Aug 05 '22 11:08 fdncred

closing this in favor of waiting to see if it's experiments pan out.

fdncred avatar Aug 31 '22 22:08 fdncred