nushell icon indicating copy to clipboard operation
nushell copied to clipboard

update ureq to 3.1.4

Open sgvictorino opened this issue 2 months ago • 4 comments

algesten/ureq#1131 fixes #16904

sgvictorino avatar Nov 08 '25 19:11 sgvictorino

As the tests now seem to time out in CI, do we need to adjust the setup of any timeouts we need to configure or is there potentially a bug in our testing setup that stalls this?

Also thanks for figuring out the root cause of that bug!

sholderbach avatar Nov 11 '25 15:11 sholderbach

I think we should time out earlier. There are some stalled requests (http_post_follows_redirect, http_put_follows_redirect, http_patch_follows_redirect) that might be caused by a ureq regression (bisected to https://github.com/algesten/ureq/commit/e84666) or latent bug in mockito (can't reproduce with another server that sends identical responses). I'll troubleshoot more when I have time.

sgvictorino avatar Nov 11 '25 20:11 sgvictorino

image Interesting that this only happens on PATCH, POST and PUT and not the others.

cptpiepmatz avatar Nov 14 '25 20:11 cptpiepmatz

Seems like it's only timing out after requests that include a body because it follows the redirect with the same content-length. I opened algesten/ureq#1135.

sgvictorino avatar Nov 14 '25 20:11 sgvictorino