nushell icon indicating copy to clipboard operation
nushell copied to clipboard
verified publisher icon nushell

Refactor `parse` command

Open IanManske opened this issue 1 year ago • 1 comments

Description

  • Switches the excess in the ParserStream and ParseStreamerExternal types from a Vec to a VecDeque
  • Removes unnecessary clones to stream_helper
  • Other simplifications and loop restructuring

IanManske avatar May 07 '24 01:05 IanManske

I'm wondering if it's possible to fix the TODOs about regex streaming like the helix team fixed it? https://twitter.com/burntsushi5/status/1774131574864273706

fdncred avatar May 07 '24 11:05 fdncred

Oh that's cool, definitely something we could try in the future. In the mean time, the bytestream PR should allow us to run the regex on each line of the stream.

IanManske avatar May 08 '24 00:05 IanManske

Thanks

fdncred avatar May 08 '24 11:05 fdncred