nushell icon indicating copy to clipboard operation
nushell copied to clipboard
verified publisher icon nushell

Remove CI and releases for `dataframe` feature

Open IanManske opened this issue 1 year ago • 4 comments

Description

Removes the CI for the dataframe feature. Also removes the nightly builds for the dataframe feature as well as the "Full" releases.

IanManske avatar May 07 '24 00:05 IanManske

Shouldn't this be done when dfrs are removed? I'm not sure we're quite ready to remove them yet. I think @maxim-uvarov and @ayax79 are still testing, please correct me if I'm wrong.

fdncred avatar May 07 '24 12:05 fdncred

I'm really incompetent here.

Yet I would like to mention:

  • IMO the current release version of the polars plugin is functioning better than dfr.
  • But it needs additional steps for installation for final users (which I guess is not a problem at all). I will send pr into the book dataframe chapter with info on how to install polars soon.

It would be cool if it were possible to install nushell plugins, including polars, with package managers (like it is already done with nushell itself).

maxim-uvarov avatar May 07 '24 13:05 maxim-uvarov

One last point, I'm good with removing dataframes from nushell, in favor of nu_plugin_polars, whenever @ayax79 and @maxim-uvarov are ready. I'd like to do it sooner rather than later but I also don't want to rush any testing that may be happening.

fdncred avatar May 07 '24 14:05 fdncred

@ayax79 is a decision-maker here; let's wait for him.

maxim-uvarov avatar May 07 '24 14:05 maxim-uvarov

Thanks for putting this together!

One other thing we address is the dataframe references inside of nu_scripts release. Once we have that and the doc updates from @maxim-uvarov, then I think we can merge.

ayax79 avatar May 07 '24 19:05 ayax79

Can't wait for the full migration!

Conceptually I think that the CI part should only go with the code itself being removed. I don't want some baggage in the repo that may not compile anymore. Sunsetting the release part itself can happen independently.

sholderbach avatar May 08 '24 07:05 sholderbach

Conceptually I think that the CI part should only go with the code itself being removed. I don't want some baggage in the repo that may not compile anymore.

Yeah, that makes sense. I'll close for whoever wants to handle removing the old dataframe crate.

IanManske avatar May 08 '24 14:05 IanManske

Just for tracking purposes: I submitted a PR that uses polars instead of dfr and added installation instructions. https://github.com/nushell/nushell.github.io/pull/1391

maxim-uvarov avatar May 09 '24 12:05 maxim-uvarov

Why not just build on this and remove nu-cmd-dataframe and the dataframe feature entirely? I think that is the plan for this release anyway

devyn avatar May 11 '24 08:05 devyn

If @ayax79 is fine with that, and he thinks it's ready, then sure. (Or, if he would like to do the honors :smile:)

IanManske avatar May 11 '24 15:05 IanManske