nushell icon indicating copy to clipboard operation
nushell copied to clipboard

Performance issue: Prompt command gets ran on every character.

Open RGBCube opened this issue 1 year ago • 1 comments

Describe the bug

As the title says, when you set a custom prompt command, like starship, it gets called every time you input another character.

This isn't really noticeable on a local machine with a good CPU, but it really makes it unusable over SSH.

Fish, bash and ZSH work fine with starship on my pretty slow VPS, but Nushell does not, as it calls starship all the time making it take too long.

How to reproduce

  1. Install starship onto a VPS
  2. Hook it up for fish and nushell
  3. Compare the responsiveness over SSH

Expected behavior

Only to run the prompt command once. If it has to redraw it all the time, it can cache the output I guess. This shouldn't be needed though, as redrawing everything atm makes it flicker. Fish handles it well.

Screenshots

No response

Configuration

key value
version 0.89.0
branch
commit_hash
build_os linux-x86_64
build_target x86_64-unknown-linux-gnu
rust_version rustc 1.75.0 (82e1608df 2023-12-21) (built from a source tarball)
cargo_version cargo 1.75.0
build_time 1980-01-01 00:00:00 +00:00
build_rust_channel release
allocator mimalloc
features default, sqlite, trash, which, zip
installed_plugins

Additional context

No response

RGBCube avatar Feb 12 '24 09:02 RGBCube

This is a known issue with reedline that we'd like to get fixed. I think it's also what makes WezTerm unusable on Windows.

fdncred avatar Feb 12 '24 12:02 fdncred