nushell.github.io icon indicating copy to clipboard operation
nushell.github.io copied to clipboard
verified publisher icon nushell

Move zoxide completer from external_completers to custom_completions

Open blindFS opened this issue 9 months ago • 2 comments

Closes #1845

blindFS avatar Mar 25 '25 12:03 blindFS

I'm wondering if this wouldn't fit better in the Cookbook. I'd like to see what @NotTheDr01ds thinks.

ysthakur avatar Mar 25 '25 18:03 ysthakur

I'm wondering if this wouldn't fit better in the Cookbook.

I also agree, maybe we should rename the "External Completers" page to just "Completions" or "Completers"?

132ikl avatar Mar 27 '25 21:03 132ikl

@blindFS Could you move these changes to the External Completers page in the Cookbook, as well as rename that page to Completions or Completers?

ysthakur avatar Jun 06 '25 20:06 ysthakur

@blindFS Could you move these changes to the External Completers page in the Cookbook, as well as rename that page to Completions or Completers?

Sorry, I don't have my computer with me in the following couple of days. Do you have the authority to modify this PR or should I close it so that you can fix it in another one?

blindFS avatar Jun 07 '25 01:06 blindFS

or just land it and move it later

fdncred avatar Jun 07 '25 12:06 fdncred

Sure, that'd be easiest

ysthakur avatar Jun 07 '25 15:06 ysthakur