nu_scripts icon indicating copy to clipboard operation
nu_scripts copied to clipboard
verified publisher icon nushell

Remove direnv hook example

Open NotTheDr01ds opened this issue 8 months ago • 3 comments

As noted in https://github.com/nushell/nushell/issues/15452, having a direnv example in nu_scripts and one in the Cookbook is a problem in that they've rarely been in sync. Since there's documentation for this in the Cookbook, let's remove it from nu_scripts and just have one going forward.

NotTheDr01ds avatar Apr 15 '25 00:04 NotTheDr01ds

Merge after 0.104 release.

NotTheDr01ds avatar Apr 15 '25 00:04 NotTheDr01ds

There are 2 files in the direnv folder. Did we mean to only remove one of them?

fdncred avatar Apr 15 '25 11:04 fdncred

Did we mean to only remove one of them?

Yes, the other appears to be an example of how to do direnv type functionality in pure Nushell (without direnv). It's just not explained. That seems to be a general problem with a lot of stuff in nu_scripts, of course.

NotTheDr01ds avatar Apr 15 '25 17:04 NotTheDr01ds

This PR has been stale since April. The commends seem to have been linear, without rejection. The last question was answered with "yes, intended". Should this be merged as-is, or something else?

Kissaki avatar Nov 16 '25 18:11 Kissaki

Yes, sorry - I just (a) ended up quite busy for a while, and (b) don't visit nu_scripts as much as I should

NotTheDr01ds avatar Nov 27 '25 00:11 NotTheDr01ds