nana icon indicating copy to clipboard operation
nana copied to clipboard
verified publisher icon nushell

Shell-alike UI/UX

Open knoopx opened this issue 3 years ago • 3 comments

this is a rebase of my previous work on https://github.com/nushell/nana/pull/32. just opening for discussion/future consideration.

knoopx avatar Jun 23 '22 15:06 knoopx

@knoopx After a quick read through, this is a summary of some (hopefully most) of the changes I see. Any 1 these could be 1 PR but having them all together makes it difficult to digest. Here's the list and (only) my opinion on the items.

  1. changes theme to "knoopx dark" vs solarized - let's keep solarized for now
  2. adds cool completion dialog - love it, let's keep it
  3. changes cwd to small form - keep it themed the old way
  4. changes they way keyboard events are captured - like it
  5. changes input prompt - like it but keep the old theme
  6. changes table/record/list rendering - like it but keep the old theme
  7. adds duration display string - like it but make it match the old theme
  8. changes the result handler - not sure
  9. adds a spinner - thing it's a good idea - keep it
  10. removes most of main.css styles - may be related to 1 - probably needs reverting to keep the old theme?
  11. has conflicts - just needs a rebase

@rgwood @jntrnr thoughts?

fdncred avatar Jun 23 '22 16:06 fdncred

No objection to the changes that add functionality. Probably easiest to discuss the big UI/design changes in Discord.

rgwood avatar Jun 23 '22 16:06 rgwood

Would love to see this broken into parts, with a separate PR for each. Things like the completions dialog are a great improvement even just by themselves.

sophiajt avatar Jun 23 '22 18:06 sophiajt