termwind
termwind copied to clipboard
Add support for borders
Hey! Here's my initial work on border support (fixing https://github.com/nunomaduro/termwind/issues/177)
I've created the base logic, and think that it would be best if I could get some maintainer help to make sure it gets fully integrated with how the rest of the Termwind framework is supposed to work.
I think since the rendering logic is kinda complex it could make sense to have this as a pseudo-element rather than a style, but that's something that's up to you. I put the heavy logic in an action class to make it more self-contained depending on how you want to handle it. I have not yet added support for colours as I just want to know if I'm on the right track first.
Hey @caendesilva thanks for the PR.
I would say we need to have the same api, with the rounded
border
border-{color}` and I would not have the padding by default.
Can you make this adjustments?
Thanks and sorry for the delay reviewing your PR.
Hey @caendesilva thanks for the PR.
I would say we need to have the same api, with the
rounded
border
border-{color}` and I would not have the padding by default.Can you make this adjustments?
Thanks and sorry for the delay reviewing your PR.
Hey! I'll try, I need to learn more about how the other components work so may take some time
no worries, any question let me know.
Thanks, Francisco.