phpinsights icon indicating copy to clipboard operation
phpinsights copied to clipboard

--fix Issues. Not fixing the things it 'fixes' and producing weird style score

Open Sergiobop opened this issue 2 years ago • 3 comments

Q A
Bug report? yes
Feature request? no
Library version 2.0.1

Im using the --fix option. The result is saying it fixed a few issues:

[OK] 🧙 ️Congrats ! 9 issues fixed

• [Style] Object operator indent:
 app/Http/Controllers/ .....php: 1 issue fixed

• [Style] Scope closing brace:
 app/Http/Controllers/ .....php: 1 issue fixed

• [Style] Space after cast:
 app/Exports/ .....php: 1 issue fixed
 app/Http/Controllers/ .....php: 1 issue fixed
 routes/ .....php: 1 issue fixed

• [Style] Cast spaces:
 app/Exports/ .....php: 1 issue fixed
 app/Http/Controllers/ .....php: 1 issue fixed
 routes/ .....php: 1 issue fixed

• [Style] Method chaining indentation:
 app/Http/Controllers/ .....php: 1 issue fixed

But it's not true, running it again, produces the same result. It's like the fixes are fake. (I use git, after using the command, there are no changes)

In addition, the style score is super different when running the --fix command (when i run with --fix, i have 97.5% style), when i don't, i have 92.6%) maybe it's related to the non-fixing issue? Thanks

Sergiobop avatar Dec 27 '21 18:12 Sergiobop

Will investigate and see what is going on here

@Sergiobop - sorry new maintainers taking over package, making notes on issues atm to take count of where we are. Are you still having this issue?

JustSteveKing avatar Mar 08 '22 12:03 JustSteveKing

Hey @JustSteveKing , thank you for your response. Yes, i still have the issue

Sergiobop avatar Mar 08 '22 13:03 Sergiobop

Thanks for the info @Sergiobop - will add it to the list as I know there have been a few issues with formatting

JustSteveKing avatar Mar 08 '22 13:03 JustSteveKing