phpinsights icon indicating copy to clipboard operation
phpinsights copied to clipboard

Add PHPStan wrapper

Open nunomaduro opened this issue 6 years ago • 1 comments

Q A
Bug report? no
Feature request? yes
Library version 1.6.0

Add PHPStan wrapper just like we did on with PHPCS: https://github.com/nunomaduro/phpinsights/blob/master/src/Domain/Insights/InsightFactory.php.

Note that: I don't want false positives on PHP Insights, so we only want to incorporate rules that are 100% accurate.

nunomaduro avatar Jun 05 '19 09:06 nunomaduro

Alright, so after I tried adding support for phpstan I ran into multiple issues and backwards compatibility things.
I think we if should add support for phpstan we have to do it by running their tool directly, not hacking into their tool.

However, phpstan's errors are missing which rule the error came from https://github.com/phpstan/phpstan/issues/3065.

olivernybroe avatar Mar 06 '20 08:03 olivernybroe