Nuno Sá

Results 70 comments of Nuno Sá

@tausen did you end up upstreaming this? If you're not comfortable with it, I can take care of it...

> Otherwise I'll come back to it soon™ Alright, I'll hold a bit more. My only rush here is to merge/close this PR :)

Yeah, either closing and waiting to get this when upgrading or merging it now... I will probably merge it as this is fairly simple.

Hi Travis, Some minor comments from side: > The currently built doc generated from this PR The link seems to be nok... > Theoretically, this does not have to live...

Do you plan to send this (maybe as RFC) upstream?

@Demon000, maybe move this into draft in the meantime...

Closing this as there was no more feedback on it....

Hi @chegbeli, As I've been pushing recently, I would like for you to send this upstream first unless there's a strong reason for not doing so... Being that said, it's...

I will give this a deeper look tomorrow. But from an early glimpse, I would already like to leave some notes: 1. Please do things on their own commit. Bindings...

@NurettinBolucu , Don't do a new commit with the review feedback. It's harder to review... Just rebase you local dev branch and force push it with the needed commits needed...