nunit3-vs-adapter icon indicating copy to clipboard operation
nunit3-vs-adapter copied to clipboard

Issue 965: Special build using pre-release of nunit.engine 4.0.0

Open manfred-brands opened this issue 2 years ago • 4 comments

Fixes #965

I left this as a draft PR as I don't expect it to be merged into master. The purpose is to get a special build that can be referenced in nunit framework nunit4 developments.

As I also not aware of the changes in the engine, I have deleted several lines in TestAdapterUtils as those classes no longer exist.

There was one other change. The name/fullname properties of the test-run node seem to no longer exist.

I testes the nuget package with nunit framework and it allows me to run tests in VS and with dotnet test

manfred-brands avatar Mar 24 '22 10:03 manfred-brands

Not sure if you agree with the version number, but the adapter seems to be one ahead of the engine/framework.

manfred-brands avatar Mar 24 '22 10:03 manfred-brands

The build seem to not be able to find the myget package when referenced in .csproj file. Trying to add to nuget.config

manfred-brands avatar Mar 24 '22 10:03 manfred-brands

@CharliePoole The engine does find the test for netcore/net6, but not for net framework. In the debugger is shows:

System.ComponentModel.Win32Exception : The system cannot find the file specified--Win32Exception
The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at NUnit.Engine.Services.TestAgency.GetAgent(TestPackage package)
   at NUnit.Engine.Runners.ProcessRunner.CreateAgentAndRunnerIfNeeded()
   at NUnit.Engine.Runners.ProcessRunner.Explore(TestFilter filter)

It seems to be looking for nunit-agent.exe binaries. I see them in the contentFiles directory.

@OsirisTerje build.cake --target=Test shows all green lines, even though it didn't find any tests.

No test is available in D:\3rd\NUnit\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net46\NUnit.VisualStudio.TestAdapter.Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

manfred-brands avatar Mar 24 '22 10:03 manfred-brands

@manfred-brands My guess is that you are running into nunit/nunit-console#1023, which is a pretty big one!

I just assigned you an issue, which is a small part of a bigger part of that issue. :-)

CharliePoole avatar Mar 24 '22 14:03 CharliePoole

I assume we don't need this anymore, as 4.5 does run nunit 4.

OsirisTerje avatar Jul 03 '23 18:07 OsirisTerje