nunit3-vs-adapter icon indicating copy to clipboard operation
nunit3-vs-adapter copied to clipboard

Only un-escape unicode character encoding color codes Fix #1124

Open Socolin opened this issue 2 years ago • 4 comments

Socolin avatar Dec 17 '23 22:12 Socolin

I was not able to run the tests on my computer, but they seems to work in github action.

Socolin avatar Dec 17 '23 22:12 Socolin

@Socolin This is still open, build issues, merge conflicts. Any chance of having a look?

OsirisTerje avatar May 12 '24 19:05 OsirisTerje

I'll take a look I did not saw the build error I was waiting for some feedback on this.

Socolin avatar May 13 '24 02:05 Socolin

Your unit test is failing. See Details, nearly near the bottom.

OsirisTerje avatar May 13 '24 08:05 OsirisTerje

Hello, the test result is not available anymore could you trigger the pipeline again so I can see the errors ? I will have time again to look at this in the coming weeks.

Socolin avatar Jul 18 '24 17:07 Socolin

I did a manual merge from main (who had changed) on the web here, and got in some compiler errors. I think it is faster if you just fix those than for me to clone your repo. Then the build should work again. It seems to only be some small glitches, braces etc

OsirisTerje avatar Jul 18 '24 18:07 OsirisTerje

Sorry for the delay, I finally got the time to take a look, I rebased the branch + force push and did the fix, all should be good now :)

Socolin avatar Jul 27 '24 18:07 Socolin

Lgtm, any comments @manfred-brands , @stevenaw ?

OsirisTerje avatar Jul 27 '24 20:07 OsirisTerje