Test discovery fails if the pdb format is "portable"

[jeromelaban]

Using version 2.1.1 of the test adapter, in VS2017 Update 2, the test discovery fails with this error:

Exception System.InvalidOperationException, Exception converting MyTest.

Upgrading the Mono.Cecil package to the latest version (0.10.0-beta6), or using full pdb format fixes the issue.

[CharliePoole]

IIRC, we can't target .NET 2 if we use the latest Mono.Cecil.

[DavidKarlas]

I guess this adapter also needs https://github.com/nunit/nunit3-vs-adapter/pull/350

[jnm2]

Who wants to take this? /cc @OsirisTerje

[rprouse]

We should implement nunit/nunit3-vs-adapter#350 although it will not fix this for Update 2 of 2017. Those changes are coming in 15.3 and even now they are hidden behind a feature flag, From the RFC,

While the changes for CLI will be available in a future release, changes for IDE are already available in Visual Studio 2017 Update 3 Preview 3 and newer builds but is hidden behind a feature flag.

[codito]

There's a port of nunit/nunit3-vs-adapter#350 to nunit2 here: https://github.com/nunit/nunit-vs-adapter/pull/160. @jnm2 @rprouse @OsirisTerje can you please review this?

[CharliePoole]

Team members receive a notice when you submit a PR but it sometimes takes a few days before someone has time to review it.

[OsirisTerje]

@codito Will review this as soon as I have 3.9 out for the NUnit3TestAdapter.

[mclark1129]

+1 On VS 2017 15.7.2. Changing to full debug symbols fixes the issue.