devshell icon indicating copy to clipboard operation
devshell copied to clipboard

Published 20 hours ago • verified publisher icon numtide

Add nested commands

Open deemp opened this issue 6 months ago • 7 comments

Partially addresses #216.

Based on #295, #297 because these PRs introduced some important changes.

  • Allow to specify commands as an attrset
  • Update docs
    • Specify that the commands attrset (commands.<name>.*) isn't available when using TOML
    • Reorganize the docs a bit

deemp avatar Jan 05 '24 22:01 deemp

Let me know when it's rebased!

zimbatm avatar Jan 07 '24 17:01 zimbatm

@zimbatm, rebased.

deemp avatar Jan 07 '24 17:01 deemp

There are some problems with types. I'll let you know when this PR is ready.

deemp avatar Jan 07 '24 18:01 deemp

@zimbatm, this PR is ready for a review.

deemp avatar Jan 08 '24 09:01 deemp

hmm, are you able to extract those cleanups in a separate PR? sorry the PR is a bit too large still

zimbatm avatar Jan 11 '24 20:01 zimbatm

Okay, now, this PR is based #295 and #297

deemp avatar Jan 13 '24 12:01 deemp

thanks, let me get those merged and then I'll do a deeper review here

zimbatm avatar Jan 14 '24 14:01 zimbatm