Ben Green
Ben Green
I would say that more testing is probably needed to call this "production ready." No load tests have been performed yet to determine memory usage (and/or leaking) or response time...
Whoa that's a big commit you got there. Anyways, I isolated the hardhat part into its own file and it exits cleanly. Maybe it's something else? https://github.com/numtel/solc-hardhat-test
On my Fedora 40 x86_64 machine, I was able to install the dependencies and get most of the tests to pass but I had to modify the `circom_tester` dependency. I...
Interesting but it doesn't seem like there's any use case for this. I've had ChatGPT rewrite the class as using a prototype so that the listeners property can be accessed...
Queuing events before adding the handler fixes it, yes, but why not just do that in the function where you create the ProgressPromise in the first place? Seems like adding...
Like, if it's happening synchronously, just move it outside the promise? ```js console.log('Running...'); await (new ProgressPromise((resolve, reject, progress) => { setTimeout(() => { progress('Done'); resolve(); }); })).progress(val => console.log(val)); ```...
I'm just trying to understand it. It does seem like it could be a worthy upgrade. Make a PR and we can do an update even if it does make...
Fine with me, just include the compiled js in there too so that it can still be used with the github url import dependency in package.json.
At the time, Symbols and built-in promises were new things so I thought it would be cool to use them. Using the symbol creates a private property on the object...
Seems to work with the simple template from the test case: ```circom template Foo(n) { signal input a[2]; a[0] === a[1]; } ``` ```json [ { "category": "Warning", "message": "The...