numpy-tutorials icon indicating copy to clipboard operation
numpy-tutorials copied to clipboard

Fail CI for warnings

Open bsipocz opened this issue 3 years ago • 5 comments

Ideally we should handle warnings raised during the tutorials, and fail CI with anything that is unexpected.

bsipocz avatar Nov 17 '22 20:11 bsipocz

Good point! I though we had this covered with the -W option for sphinx-build, but it turns out that doesn't extend to warnings raised during notebook execution.

rossbar avatar Nov 18 '22 05:11 rossbar

yep, the code content and rendering are handled separately.

You can assign this to me, though I'm not sure when I get to actually do something about it.

bsipocz avatar Nov 18 '22 05:11 bsipocz

Of course - feel free! I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level.

rossbar avatar Nov 18 '22 05:11 rossbar

Of course - feel free

I can't do that ;)

I also opened https://github.com/executablebooks/MyST-NB/issues/459 about this as I couldn't find a good way to handle this at the config-level.

Ideally, a standard pytest config should do the trick, but f course it doesn't work out of the box :(

bsipocz avatar Nov 18 '22 05:11 bsipocz

I'm going to go ahead and re-open this - #203 fixed the current batch of warnings, but I agree with the original premise that we need something in CI to fail on runtime warnings.

rossbar avatar Jan 23 '24 18:01 rossbar

I believe this is no longer directly relevant with the JB2 build/execution toolchain, right? Once we tidy things up enough to enable the --strict flag (already recorded as a follow-up in #280), that should resolve this issue?

WDYT @bsipocz - I'm happy to keep this open if it's still relevant, though I suspect the discussion isn't anymore after the infrastructure switch!

rossbar avatar Nov 14 '25 20:11 rossbar

Yes, we can close this as it's a duplicate for strict

bsipocz avatar Nov 14 '25 22:11 bsipocz