Elementary Freya Support [$15]

[bilelmoussaoui]

Hello, I would like to report some missing icons/symlinks

• [x] airplane-mode
• [x] airplane-mode-symbolic
• [x] align-horizontal-center
• [x] align-horizontal-left
• [x] align-horizontal-right
• [x] align-vertical-bottom
• [x] align-vertical-center
• [x] align-vertical-top
• [x] application-x-fictionbook+xml
• [x] applications-education
• [x] applications-internet-symbolic
• [x] appointment-new-symbolic
• [x] aptdaemon-delete
• [x] aptdaemon-download
• [x] aptdaemon-setup
• [x] aptdaemon-update-cache
• [x] aptdaemon-upgrade
• [x] aptdaemon-working
• [x] audio-input-microphone-symbolic
• [x] audio-volume-high-symbolic
• [x] audio-volume-low-symbolic
• [x] audio-volume-medium-symbolic
• [x] audio-volume-muted-blocking-symbolic
• [x] audio-volume-muted-symbolic
• [x] battery-ac-adapter
• [x] battery-mouse-000 #432
• [x] battery-mouse-020 #432
• [x] battery-mouse-040 #432
• [x] battery-mouse-060 #432
• [x] battery-mouse-080 #432
• [x] battery-mouse-100 #432
• [x] battery-phone-000 #432
• [x] battery-phone-020 #432
• [x] battery-phone-040 #432
• [x] battery-phone-060 #432
• [x] battery-phone-080
• [x] battery-phone-100
• [x] bluetooth #438 -wontfix-
• [x] bluetooth-active-symbolic
• [x] bluetooth-disabled-symbolic
• [x] bluetooth-paired-symbolic
• [x] computer-apple-ipad
• [x] config-language
• [x] dialog-information-symbolic
• [x] distribute-horizontal-right
• [x] distribute-vertical-bottom
• [x] distribute-vertical-top
• [x] document-export-symbolic
• [x] document-import-symbolic
• [x] drive-harddisk-symbolic
• [x] edit-clear-symbolic
• [x] edit-redo-rtl
• [x] edit-undo-archive
• [x] edit-undo-rtl
• [x] event-new
• [x] folder-tag
• [x] format-indent-less-rtl
• [x] format-indent-more-rtl
• [x] format-text-none
• [x] go-back-rtl
• [x] go-first-rtl
• [x] go-forward-rtl
• [x] go-jump-rtl
• [x] go-last-rtl
• [x] go-next-rtl-symbolic
• [x] go-next-symbolic
• [x] go-previous-rtl-symbolic
• [x] go-previous-symbolic
• [x] help-info
• [x] image-vnd.adobe.photoshop
• [x] image-x-3ds
• [x] input-touchpad
• [x] internet-radio
• [x] jockey-proprietary
• [x] library-audiobook
• [x] library-places
• [x] library-podcast
• [x] mail-archive
• [x] mail-mailbox
• [x] media-import-audio-cd
• [x] media-playback-pause-symbolic
• [x] media-playback-start-symbolic
• [x] media-seek-backward-rtl-symbolic
• [x] media-seek-backward-symbolic
• [x] media-seek-backward-symbolic-rtl
• [x] media-seek-forward-rtl-symbolic
• [x] media-seek-forward-symbolic
• [x] media-seek-forward-symbolic-rtl
• [x] media-skip-backward-rtl
• [x] media-skip-backward-rtl-symbolic
• [x] media-skip-backward-symbolic
• [x] media-skip-backward-symbolic-rtl
• [x] media-skip-forward-rtl
• [x] media-skip-forward-rtl-symbolic
• [x] media-skip-forward-symbolic
• [x] media-skip-forward-symbolic-rtl
• [x] model
• [x] network-cellular-signal-excellent-symbolic
• [x] network-cellular-signal-good-symbolic
• [x] network-cellular-signal-none-symbolic
• [x] network-cellular-signal-ok-symbolic
• [x] network-cellular-signal-weak-symbolic
• [x] network-vpn-lock-symbolic
• [x] network-wired-offline-symbolic
• [x] network-wired-symbolic
• [x] network-wireless-hotspot
• [x] network-wireless-offline-symbolic
• [x] network-wireless-signal-excellent-symbolic
• [x] network-wireless-signal-good-symbolic
• [x] network-wireless-signal-none-symbolic
• [x] network-wireless-signal-ok-symbolic
• [x] network-wireless-signal-weak-symbolic
• [x] nm-signal-0-secure
• [x] node-add
• [ ] node-align-horizontal
• [ ] node-align-vertical
• [x] node-break
• [x] node-cusp
• [x] node-delete
• [x] node-delete-segment
• [ ] node-distribute-horizontal
• [ ] node-distribute-vertical
• [ ] node-insert
• [x] node-join
• [x] node-join-segment
• [x] node-smooth
• [x] node-symmetric
• [x] notification-audio-volume-high
• [x] notification-audio-volume-low
• [x] notification-audio-volume-medium
• [x] notification-audio-volume-muted
• [x] notification-audio-volume-off
• [x] notification-battery-low
• [x] notification-device-eject
• [x] notification-disabled
• [x] notification-disabled-symbolic
• [x] notification-display-brightness
• [x] notification-keyboard-brightness
• [x] notification-network-wired
• [x] notification-network-wireless
• [x] notification-network-wireless-disconnected
• [x] notification-new-symbolic
• [x] notification-power
• [x] notification-symbolic
• [x] notification-wifi-enabled
• [x] object-group
• [x] object-merge
• [x] object-to-path
• [x] object-ungroup
• [x] office-database
• [x] onboard-panel
• [x] pane-hide-symbolic
• [x] pane-hide-symbolic-rtl
• [x] pane-show-symbolic
• [x] pane-show-symbolic-rtl
• [ ] playlist-queue
• [ ] playlist-similar
• [x] ppa
• [x] preferences-bluetooth
• [x] preferences-desktop-accessibility
• [ ] preferences-desktop-accessibility-pointing
• [ ] preferences-desktop-accessibility-symbolic
• [ ] preferences-desktop-accessibility-zoom
• [ ] preferences-desktop-applications
• [x] preferences-desktop-display
• [ ] preferences-desktop-keyboard
• [ ] preferences-desktop-locale
• [ ] preferences-desktop-notifications
• [ ] preferences-desktop-online-accounts
• [ ] preferences-desktop-peripherals
• [ ] preferences-desktop-sound
• [ ] preferences-desktop-wallpaper
• [x] preferences-system-power
• [x] preferences-system-privacy
• [x] preferences-system-time
• [x] printer-printing
• [x] printer-printing-symbolic
• [x] process-working-symbolic
• [x] processor
• [x] security-medium
• [x] segment-curve
• [x] segment-line
• [ ] selection-add
• [x] selection-break
• [ ] selection-checked
• [x] selection-combine
• [x] selection-exclude
• [ ] selection-remove
• [x] stroke-to-path
• [x] system-shutdown-symbolic
• [x] system-suspend
• [x] tag
• [x] user-idle
• [x] user-typing
• [x] view-private

Already added icons from old issue

• [x] application-pgp
• [x] dialog-ok-apply
• [x] document-import
• [x] edit
• [x] edit-flag
• [x] edit-mark
• [x] image-adjust
• [x] image-auto-adjust
• [x] image-red-eye
• [x] mail-forwarded
• [x] non-starred
• [x] non-starred-grey
• [x] object-straighten
• [x] open-menu
• [x] starred
• [x] tablet
• [x] tag-new

As there's too many icons, i couldn't upload them all.. So if someone wants working on this i would be happy to try to do it. I will add more asap. Thank you

[andia89]

Concerning your second screenshot: None of those icons is supported (except the trash-can) there are just a few .pngs in the Numix-folders that are remnants from the gnome-icon theme i suppose. So you can add them to your list. The "drafts" icon is probably gtk-edit

The missing icons in your second screenshot (you can add them to your list):

• mail-inbox ("Inbox")
• mail-outbox ("Outbox")
• mail-sent ("Sent mail"; all 3 in places)
• tag-new ("Labels", actions)
• mail_spam ("Spam", actions)

but I wasn't able to find "Drafts"

[bilelmoussaoui]

I will add those icons soon. I'm trying to find an other icon but i couldn't find it anywhere..

[bilelmoussaoui]

I did used a python script to check the difference between two folders.

folder1 = '/usr/share/icons/elementary/'
folder2 = '/usr/share/icons/Numix/'
folders_to_compare = ['actions','animations','categories','devices','emblems','mimes','places']

def get_extension(f):
    extension = f.split(".")
    return extension[len(extension) - 1]

def diff_folders(folder1, folder2,folders_to_compare):
    for folder in folders_to_compare:
        dir1 = os.listdir(folder1+folder)
        for d1 in dir1:
            if d1.isdigit() and os.path.isdir(folder2+d1+"x"+d1+"/"+folder):
                dir2 = os.listdir(folder1+folder+"/"+d1)
                dir3 = os.listdir(folder2+d1+"x"+d1+"/"+folder)
                for d2 in dir2:
                    if not(d2 in dir3) and get_extension(d2) == "svg": 
                        print("- [ ] " +folder1+folder+"/"+d1+"/"+d2)



diff_folders(folder1,folder2,folders_to_compare)

[bilelmoussaoui]

@Foggalong I've added a bounty on this and on #450 , would you like to add them to the title? :) Thanks!

[Foggalong]

I've contacted the Bounty Source team about why our account isn't working properly. They do a good thing with the site, but it's not half buggy at times.

[andia89]

@bil-elmoussaoui This is true for #450 as well. Is it possible to remove double counted icons (probably by slightly modifying your python script?). help-info.svg for example is here 6 times...

[bilelmoussaoui]

I updated this one ;)

[andia89]

@bil-elmoussaoui Hmm it seems to me that you made some errors. A lot of icons are already present in numix (network-wired network-wireless, etc...) Maybe you compared to an outdated version?

[bilelmoussaoui]

Nop i'm using the latest version of both, i guess this happend because i'm comparing folders and some of icons are in devices in Numix and they're somewhere else in Elementary :P

[andia89]

Ah ok. I'll try to think of some short bash commands to show the differences in both files. Something using diff might do the trick...

[andia89]

@bil-elmoussaoui I figured out an easy way to do this, if you could run that it shows really only the icons that are in elementary icon theme and not in Numix or Numix-Circle

#!/bin/bash

diff=$(find "$1" -regex ".*\.\(svg\|png\)" -printf "%f\n" | sed 's/\..*//' | sort | uniq)
for var in ${@:2}
do
    first=$(find "$var" -regex ".*\.\(svg\|png\)" -printf "%f\n" | sed 's/\..*//' | sort | uniq)
    diff=$(comm -23 <(echo "$diff") <(echo "$first"))
done

for f in $diff
do
    echo  "- [ ] "$f
done

EDIT2: I redid my script which works pretty good now. Call it by doing script /path/to/which/you/want/to/compare/ /path/to/base/ /path/to/circle/

[bilelmoussaoui]

@wa4557 i tried this and i have more than 500 lines in meld2.txt :P

[andia89]

I get 318 :?

[bilelmoussaoui]

I will check this again later

[Foggalong]

Just thought I'd join in - I too wrote a script to do this when I was on a quest to make Circle a more complete app theme :P

[dirtydancing]

Wow, quite a number of icons listed here :) Looking at the list, I can tell that e.g. printer-symbolic.svg definitely is present already in Numix base.

I am wondering: are all of these icons actually displayed in elementary OS?

E.g., I noticed that current Adwaita icon theme with Arch/GNOME 3.16 contains numerous "symbolic" icons more than Numix base (not talking about the new active app "symbolic" icons that are dealt with in https://github.com/numixproject/numix-icon-theme/issues/485). Still, I tend to report/push those only when I actually come across them, such as recently network-wired-disconnected-symbolic.svg, cf. https://github.com/numixproject/numix-icon-theme/issues/547. In Adwaita, e.g. there is also network-wired-acquiring-symbolic.svg, but in contrast to network-wireless-acquiring-symbolic.svg, so far I have not actually seen that one displayed in GNOME Shell, so I have not (yet) reported/pushed it.

[andia89]

@dirtydancing I agree. I'm a bit reluctant to design these icons, because I fear that a lot of these icons are not needed (maybe the aren't used anymore; same goes for #450). I think it's a better approach to only fix icons that are really displayed somewhere. I personally haven't come across a non Numix icon (that is themeable) for a very long time...

[Foggalong]

Even if it's not something users come across it's good to have even the obscure ones so that when they do show up everything stays consistent.

[andia89]

It's definitely the ultimate goal to have all the icons from all the icon themes present in numix, but on the other hand in circle you "only" fix icons if users report them i.e. they are displayed somewhere and bother them. By using this approach there is automatically some kind of "priority" which icons needs to be designed (those that are reported and seen by users).

By doing it this way and making just huge lists, a lot of effort is probably being put in creating unnecessary icons that are probably outdated and not used anymore... So the best way would be to just ditch the inheritance line in Numix, and let the user report all those ugly hicolor icons that show up :P

[Foggalong]

We actually don't with Circle - about a year ago I did exactly this, and went through all the major icon themes and made sure we covered all the app icons from all of them. It ended up being over a 1000 new icons and symlinks but they're all now in Circle. I did that then because we were at the lowest open issue count we'd ever had and didn't have much else to prioritise. We're now getting to a similar point with Numix Base.

The big problem is that most users never report missing icons. If you look through any screenshot community you'll find hundreds of people using icon themes with apps icons, and panel icons, and all sorts of things missing and bugged.

That aside, I'm looking down this list and seeing icons reported by @bil-elmoussaoui that we actually already have. It might be worth revising this list.

[andia89]

Fair enough. In that case I'll try and contribute some of the icons. Although I might spare less time the next few weeks for creating icons :(

[Foggalong]

No worries about spending time on it, people do what they can :)

[Foggalong]

@bil-elmoussaoui @palob @wa4557 @dirtydancing

Just a PSA because you all seem to be working on lists like this - after you've done an icon on the list, don't remove it's entry from that list. Just put a tick in the box (or me to do so if you can't) so that we can keep track of progress and also have somewhere to reference back to if things go wrong.

[andia89]

@bil-elmoussaoui When you're cleaning up this list (good luck for your finals btw. :) you have to consider that a few of the icons in your list are actually app icons and should be reported in circle rather than here And: could you use this package here to compare the icon themes? This should be the most up to date one: https://code.launchpad.net/elementaryicons

[bilelmoussaoui]

@wa4557 i checked this again and all the icons does not exists. For the preferences-*.svg icons, they must be add in Circle and in Base too

[dirtydancing]

I will say again that printer-symbolic.svg already exists :) (in 16x16/status, 22x22/status, 24x24/status and in scalable/devices)

[andia89]

@bil-elmoussaoui Have you used the script I provided? It's quite robust. I get something like 509(?) icons that are missing. mail-move.svg for examle is also already there

[bilelmoussaoui]

@wa4557 I tried your script but i got a lot of missing icons.. Which is not the case. I'm using elementary OS as a default desktop with Numix and i only have a few missing icons

[andia89]

Just because you don't see them doesn't mean they are not missing :P You should still report them

[bilelmoussaoui]

@wa4557 Done :P I used an other script to do that