Add Colour to Document Icons

[mueller-ma]

The "i" should be centered: https://github.com/numixproject/numix-icon-theme/blob/master/Numix/64/actions/document-properties.svg

Example KeePassXC: Thunderbird menu:

[palob]

The issue is that there is a sheet underneath the i which isn't discernible from the background.

[Foggalong]

@mueller-ma Which GTK theme is this with?

[mueller-ma]

I'm using Cinnamon with the theme from Apricity OS with your icons. The icons provided by them should look quite familiar to you (https://github.com/Apricity-OS/apricity-icons/tree/master/Apricity%20Icons/apps/scalable). https://github.com/Apricity-OS/apricity-themes-cinnamon https://github.com/Apricity-OS/apricity-themes-gnome

[Foggalong]

Gotta love that they've forked the icon theme and then haven't updated t for 3 years. The number of bug fixes that have occurred in that time is crazy. I'll message the devs see if we can't fix that.

In the mean time, @mueller-ma can you verify this happens with our master version of the theme?

[mueller-ma]

They shut down Apricity OS a few years ago: https://apricity-os.github.io/ I'm using an about one month old clone of https://github.com/numixproject/numix-icon-theme-circle and to fix the folder symlinks https://github.com/numixproject/numix-icon-theme-square.

[Foggalong]

Oh... is it just the GTK theme that you're using then? Might be worth checking whether the themes they were forked from have been updated since.

[mueller-ma]

I don't think the issue is related to a theme, as the icon is already shifted here: https://github.com/numixproject/numix-icon-theme/blob/master/Numix/64/actions/document-properties.svg Using the default cinnamon theme the issue still exists.

[Foggalong]

Aye, it being shifted wasn't what I was talking about because that's the intended design of the icon. I was curious whether the updated theme used a different background colour to what we use for paper sheets (which is what's causing it to appear like there's a floating i).

The specific issue of the colours clashing with the GTK theme is something which will affect more than just this icon though. I'm not sure how we properly address that because (other than not using any greyscale background symbols) there'll always be some colour which causes this problem.

It might be something which we mitigate using symbol on symbol designs instead, without actually losing the sheet iconography.

[palob]

Maybe a slight yellowish tint for the sheet?

[Foggalong]

Yeah, that could work if we do that for all pages. Will have to do some checks around to make sure it doesn't clash too much with the colours used by the most popular GTK themes (obvs not gonna be able to avoid that for all of the niche, more colourful ones).

[mueller-ma]

Could you add a small black border to the sheet?

[Foggalong]

@mueller-ma Borders like that generally wouldn't fit in - if you look across the various different types of icon in the Numix themes, very few of them have borders. If it's to be distinguished in any way it'll have to be through colour

[palob]

The sheet could have lines on it if it doesn't look too busy.

[Foggalong]

Lines could work, but I think it'd have to be in combination with something else otherwise the lines will similarly just be floating.

[palob]

Maybe we should use the grey from the mimetype icons here. On second thought this might not contrast enough against grey backgrounds.