numix-icon-theme icon indicating copy to clipboard operation
numix-icon-theme copied to clipboard

Lollypop not fully displaying folder-music-symbolic icon

Open hlechner opened this issue 8 years ago • 5 comments

@palob (Jan 7 2017):

Thanks for your research, @hlechner.

I've just come across an isuue which might or might not be related. For tracks without album assignment in the metadata Lollypop shows folder-music-symbolic as cover art for default. For smaller sizes and SVG themes though the icon seems to be clipped the wrong way (tested with Numix, elementary, Papirus).

Here's a screenshot from ~/.cache/lollypop/ image

With breeze however`` everything is rendered correctly. They have got

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"> as the first line.


@hlechner (jan 8 2017):

@palob What is going on in this case: lollypop instead of use the full size they just try to adjust the icon just in the middle of the image, which is a lot lower size then we expect. Look this example: image

To lollypop shows the _48 correctly I have changed the index.html from:

[scalable/places]
Size=16
MinSize=16
MaxSize=512
Context=Places
Type=Scalable

to:

[scalable/places]
Size=16
MinSize=8
MaxSize=512
Context=Places
Type=Scalable

It's a strange application behavior, but I think it was developed that way. To change the MinSize to fix just for lollypop it maybe generate strange behavior in different apps.

Lollypop if not allowed to resize the icon for the size needed they will use the MinSize and crop it, that is why you have seen just part of the icon being generated.


@palob (Jan 8 2017):

Alright, thanks. As far as I can see a lot of other themes have got MinSize=8 for Size=16. @wa4557 @hlechner Should we change it or do you know of any negative side effects?


@wa4557 (Jan 8 2017):

@palob Reducing MinSize of smalles icons is definitely no problem, if we don't touch any other sizes.


@hlechner (Jan 8 2017):

If there is no problem with MinSize being "8" let's change it then.

Oh, just remembering about MinSize due to this lollypop issue:

@palob shows the screenshot of the images of 45, 48 and 200. But I found on the same folder the 32 version too.

The MinSize "8" is not enough to the 32. it needs to be even lower. Numix icon will "suffer" more than Breeze because the icon itself uses all 16px and the breeze one have some "border" pixels invisible/not used.

Even with the solution in our side I believe we should report to them, they can produce the images from different ways. @palob could you report this issue to the developers?

hlechner avatar Jan 11 '17 07:01 hlechner

Just to keep the things better organized due to different topics, opening a different issue for this subject.

Originally troubleshooted on #1076

hlechner avatar Jan 11 '17 07:01 hlechner

Switching to MinSize=8 for all scalable Numix icons doesn't entirely fix it for me on a 1366x768 screen.

palob avatar Jan 11 '17 17:01 palob

Could you give more details @palob ?

It fixes to me the 45 and 48 but not the 32, which is cropped even in the breeze one, however the icon itself do not use all the 16px from vertical or horizontal (breeze), so there is no visible problem for breeze in 32.

hlechner avatar Jan 12 '17 01:01 hlechner

Oh, by the way, you must remove the cache from ~/.cache/lollypop/ (just the folder-music-symbolic ones), otherwise you gonna use the old generated image.

hlechner avatar Jan 12 '17 01:01 hlechner

Looks like this for me (of course I deleted the cache files):

lollypop-folder-music

The 204 one is glitchy: folder-music-symbolic_204

palob avatar Jan 12 '17 01:01 palob