numix-core icon indicating copy to clipboard operation
numix-core copied to clipboard

gen.py: SVG to PNG conversion uses deprecated Rsvg.Handle.close

Open BlueManCZ opened this issue 3 years ago • 4 comments

Works fine, but I'm getting this warning.

Generating Linux theme...
./gen.py:102: DeprecationWarning: Rsvg.Handle.close is deprecated
  svg.close()
Done!

https://developer.gnome.org/rsvg/stable/RsvgHandle.html#rsvg-handle-close

BlueManCZ avatar Apr 16 '21 11:04 BlueManCZ

Yeah noticed tat too the other day, had a half hearted look through the rsvg APIs to see what they'd replaced it with and couldn't see anything obvious :sweat_smile:

Foggalong avatar Apr 16 '21 21:04 Foggalong

This section of the docs might be helpful here: https://lazka.github.io/pgi-docs/Rsvg-2.0/classes/Handle.html#Rsvg.Handle.new

founderio avatar May 08 '21 16:05 founderio

I did some script work in #4780 and was thinking of tackling this then, but reading these docs it sounds like it's the whole method of reading SVGs that's changed rather than just .close. @bilelmoussaoui I don't suppose this is an issue you've ran into with hardcode-tray?

Foggalong avatar Sep 26 '21 17:09 Foggalong

I also noticed this. It seemed like a simple fix, but then I started experimenting with a code and it looks like most of the function has to be rewritten to fully avoid deprecation.

BlueManCZ avatar Oct 09 '21 14:10 BlueManCZ