Quick box escape handler doesn't work a second time in Opera
It also used to not work a second time if there was no form in WebKit until I added a hacky body event handler. What is different between the two qc box invocations?
Any reason why we're using all these crazy event handlers and not the closeOnEscape option?
We are using the closeOnEscape option—it's what handled the first close action, but not the subsequent ones.
Can you point me to that line? I can't find it.
closeOnEscape is enabled by default. The crazy event handler only exists so we don't roll our own event handler and instead use the widget's built the same one as closeOnEscape, delivering it the event from outside the qc box (closeOnEscape is bound to the widget).
From IRC:
<numist> JonXP: in webkit as long as the textarea has focus then closeOnEscape always works correctly
<numist> JonXP: if you are blocked (squelchee), the textarea never gets focus (there is none) and the closeOnEscape handler only fires on the first close. opening and hitting escape again delivers the keydown to body on webkit.
<numist> JonXP: I haven't looked at Opera yet, but it sounds eerily similar.
I can't reproduce this problem in Opera 11.61 1287 on OS X 10.7.3, but key navigation doesn't work when a page loads until I click somewhere in the document, so there's still some work to be done here.
Has anyone else been able to reproduce this on develop?
Apparently this shit is still inconsistent on Opera/Windows. I have the same version on OS X and it works fine with the workarounds committed earlier in this issue. Anyone have a Windows machine and can (or can't!) reproduce the quick box not working as intended?
I'm beginning to understand Marco Arment's perspective, where it's easier to make shit work properly in (and more people use) IE6 (IE9 for us, though cumulatively IE6 - IE8 outnumber Opera users as well) than Opera.