nupic.core-legacy icon indicating copy to clipboard operation
nupic.core-legacy copied to clipboard

missing use of more restrictive/descriptive UInt where suitable

Open rhyolight opened this issue 9 years ago • 2 comments

This is a small issue, asking to use the most restrictive data type possible, which is a good practice. For example size should be a UINt and not an int.

rhyolight avatar May 24 '16 23:05 rhyolight

I think this issue is just saying "The encoders' getOutputWidth method should return a UInt, not an int". That sounds reasonable. I'd support that change, but I think https://github.com/numenta/nupic.core/pull/962 is unlikely to get merged, so you might want to do this as a separate PR.

mrcslws avatar May 30 '16 19:05 mrcslws

I think it's on more places, getOutputWidth is an example; although it's a low priority issue.

breznak avatar May 31 '16 15:05 breznak