nupic.core-legacy icon indicating copy to clipboard operation
nupic.core-legacy copied to clipboard

Provide PackageConfig module for CMake

Open breznak opened this issue 8 years ago • 5 comments

so nupic.core libraries can be easily detected & included by 3rd party C++ programs.

~~https://cmake.org/Wiki/CMake:How_To_Find_Libraries~~

EDIt: reference of others https://github.com/numenta/nupic.core/blob/master/CMakeLists.txt

Ok, an update, we probably shouldn't write our own FindXXX.cmake

Do not write find modules for packages that themselves build with CMake. Instead provide a CMake package configuration file with the package itself. See our tutorials on CMake Packages. But, instead just create a package config

https://cmake.org/Wiki/CMake/Tutorials/Packaging https://cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

The desired result is: We can call find_package(NupicCore) in an external cmake repo and use the includes/libraries/binaries/flags from this project.

breznak avatar Sep 21 '16 07:09 breznak

@numenta/nupic-committers Haven't we tried this before?

rhyolight avatar Sep 23 '16 15:09 rhyolight

Not exactly. I think @breznak is suggesting we provide a generic CMake module so that consumers of nupic.core can integrate it easily into their own CMake builds. 👍 from me.

oxtopus avatar Sep 23 '16 15:09 oxtopus

👍 from me as well

scottpurdy avatar Sep 23 '16 17:09 scottpurdy

Bump. Is anyone linking their 3rd party (cmake based) app to nupic.core?

Ok, an update, we probably shouldn't write our own FindXXX.cmake

Do not write find modules for packages that themselves build with CMake. Instead provide a CMake package configuration file with the package itself. See our tutorials on CMake Packages.

But, instead just create a package config https://cmake.org/Wiki/CMake/Tutorials/Packaging https://cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

breznak avatar Mar 02 '17 11:03 breznak

Thanks for the update. No one is currently planning on working on this at the moment.

rhyolight avatar Mar 09 '17 23:03 rhyolight