Andrei Subbota comments

Results 44 comments of


                                            Andrei Subbota

New rubygems index usage

Hi maintainers – @rikas @tomlea @reggieb @sonots @tnir Could you take a look at this PR and merge if it looks good? Thanks!

New rubygems index usage

> You should update this pull request by commenting on it. I do.

Fix issue where array params are sometimes omitted when `array_use_braces` is true

Hi @olivier-thatch, a quick fix for this PR could be: ```diff diff --git a/lib/grape-swagger/doc_methods/move_params.rb b/lib/grape-swagger/doc_methods/move_params.rb index c8417ce..12c6477 100644 --- a/lib/grape-swagger/doc_methods/move_params.rb +++ b/lib/grape-swagger/doc_methods/move_params.rb @@ -136,7 +136,7 @@ module GrapeSwagger return if...

Fix issue where array params are sometimes omitted when `array_use_braces` is true

I looked more closely at the PR and noticed we have incorrect behavior for nested arrays. The type `Array[Array[String]]` collapses into `String`, so `document_array_param` only ever sees one dimension. As...

Update Geminabox dependency fetching with Adapter pattern

@tnir May I ask you to take a look at the PR?

Update Geminabox dependency fetching with Adapter pattern

@rikas @tnir Feel free to let me know if I should stop pinging you and/or should communicate in a different more efficient way (slack/discord/telegram/etc) about the "Gem-In-A-Box".

Update Geminabox dependency fetching with Adapter pattern

> Failed conditions > 30.2% Duplication on New Code (required ≤ 3%) Duplication in specs should be okay as for me. Just the repetition of the setup stuff before execution...

Update Geminabox dependency fetching with Adapter pattern

@tnir Can you look at the PR, please?

Update Geminabox dependency fetching with Adapter pattern

![sad-pepe](https://github.com/user-attachments/assets/fae66b6d-1bc1-4ae7-9b93-806e8059dbd3)

Reimplement Danger on pull_request_target

Something like this https://github.com/ruby-grape/grape/pull/2632/files ?