llvmlite icon indicating copy to clipboard operation
llvmlite copied to clipboard

python setup.py clean --all does not remove ffi/build

Open ARF1 opened this issue 5 years ago • 4 comments

If one calls python setup.py build the directory ffi/build is created. python setup.py clean --all does not remove it however.

This is a problem because stale builds can persist. For example pip install . fails because of this if python setup.py build was previously executed.

ARF1 avatar Mar 30 '20 15:03 ARF1

@ARF1 thanks for submitting this. Can you discern, if this caused by the code Numba developers wrote in the setup.py or is this a failure of the Python build system?

esc avatar Mar 31 '20 07:03 esc

@esc I have never really written a non-trivial setup.py but I think setup.py is to blame. - At least indirectly: From what I can tell at a glance ffi/build is created by ffi/build.py - which is somehow called by setup.py. But unless setup.py is told about the directory created by ffi/build.py it has no way to know about it. - That is just my guess though. I have not really looked into it.

ARF1 avatar Mar 31 '20 11:03 ARF1

@sklam wrote this originally, and it was doing some hacky things to try to handle building a standalone shared library that isn't a Python extension. Not sure if he recalls how this was supposed to work.

seibert avatar Mar 31 '20 13:03 seibert

Fix in #569

ARF1 avatar Apr 01 '20 08:04 ARF1