felix-wang

Results 69 comments of felix-wang

Thanks @Vision0220 for pointing it out. Fixed in #790. Pleas try it again.

awsome job. The current PR cannot pass CI checking. Please follow this guidelines https://github.com/jina-ai/jina/blob/master/CONTRIBUTING.md

BTW., please also use `pre-commit` to format your codes ``` $ pre-commit install $ git commit -am "feat: nebullm backend" ```

@morgoth95 how is going now? Just wondering do we have the chance to merge this PR this week?

@morgoth95 Congrats. `nebullvm v0.3.0` comes yesterday, very cool. And there are still some bad commit messages in this PR, to fix them please refer to https://github.com/jina-ai/jina/issues/553

FYI, this PR has one ore more **bad commit messages**, ``` ⧗ input: docs: Fix typo in docs ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ```

@morgoth95 Please rebase this PR so that it does not show unwanted commits

@morgoth95 please remember to install pre-commit to format your code before commits: ``` $ pre-commit install $ git commit -am "fix: xxxx" ```

@morgoth95 The unittest seems broken

@morgoth95 Hi, I hope you are well. Did you get a chance to continue this PR to pass the unit test?