numat
Add support for Alicat BASIS devices
The Alicat BASIS devices have many changes from the standard devices (the only closed loop variable available is mass flow, there is no 'D' term in the PID tuning, the data frame is different, etc). This updated driver allows most of the functionality expected from the standard device on the BASIS devices.
This has been tested on actual hardware and works. I've also slightly updated the example code in the readme, since that was for a TCP connection and most of our users use serial and were getting confused.
Let me know if there's anything I should change. I did use a more modern IDE this time so we shouldn't be seeing any issues with CR/LF etc.
I did use a more modern IDE this time so we shouldn't be seeing any issues with CR/LF etc.
(only commenting on this aspect right now; I'll review the rest later).
OK, great - that avoided most of the formatting issues from Notepad++.
The remainder are because we run ruff as an additional linter. This can be done:
- from the command line
python3 -m pip install ruff && ruff --check . - as a VSCode plugin
- as a PyCharm plugin
- as a Pulsar package
- or perhaps plugins for other editors (not sure what you're using)
I fixed the lint issues by pushing https://github.com/numat/alicat/pull/121/commits/22a4518ffdece8d0efc27dbe3d7a2e55cf08b6c9
Got it, I'll start using ruff as well. Let me know how the rest of the review goes!