numaflow icon indicating copy to clipboard operation
numaflow copied to clipboard

more type-safe version compatibility check for monovertex

Open KeranYang opened this issue 5 months ago • 0 comments

Posting on behalf of @vigith :

Currently in mono vertex version check, we are directly comparing version strings. This is for both numaflow and sdk. This involves a lot of string manipulations, converting to semver Version type and converting back, which doesn't leverage the type check capability offered by rust. We should consider creating our own NumaflowVersion type to unify the comparison.

@vigith Please edit if this doesn't accurately reflect your thoughts. Thanks!

Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

KeranYang avatar Sep 19 '24 19:09 KeranYang